Proxmark3 community

TomCyber

Member

Registered: 2010-02-15

Posts: 10

Buffer overflow when issuing "data plot"

Hi folks,

I am running into problems, when issuing the command "data plot" in my proxmark3 binary compiled with the lates svn sources on linux kernel 2.6.31-20 with libqt4-dev present. Compilation runs without errors:

(....)
g++ -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui   -Wall -O3 -c -o obj/proxgui.o proxgui.cpp
g++ -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui   -Wall -O3 -c -o obj/proxguiqt.o proxguiqt.cpp
/usr/bin/moc-qt4 -oproxguiqt.moc.cpp proxguiqt.h
g++ -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui   -Wall -O3 -c -o obj/proxguiqt.moc.o proxguiqt.moc.cpp
g++ -DQT_SHARED -I/usr/include/qt4 -I/usr/include/qt4/QtCore -I/usr/include/qt4/QtGui   -Wall -O3 obj/proxmark3.o obj/crc16.o obj/iso14443crc.o obj/data.o obj/graph.o obj/ui.o obj/cmddata.o obj/cmdhf.o obj/cmdhf14a.o obj/cmdhf14b.o obj/cmdhf15.o obj/cmdhflegic.o obj/cmdhw.o obj/cmdlf.o obj/cmdlfem4x.o obj/cmdlfhid.o obj/cmdlfti.o obj/cmdparser.o obj/cmdmain.o obj/proxusb.o obj/proxgui.o obj/proxguiqt.o obj/proxguiqt.moc.o -L/opt/local/lib -L/usr/local/lib -lusb -lreadline -lpthread -lQtGui -lQtCore   -o proxmark3
(....)

The binary works perfectly well - until it comes to the point where I want to plot the data. Here I get a buffer overflow with the following Backtrace:

proxmark3> data plot
proxmark3> *** buffer overflow detected ***: ./proxmark3 terminated
======= Backtrace: =========
/lib/tls/i686/cmov/libc.so.6(__fortify_fail+0x48)[0x75ced8]
/lib/tls/i686/cmov/libc.so.6[0x75bf10]
/lib/tls/i686/cmov/libc.so.6[0x75b648]
/lib/tls/i686/cmov/libc.so.6(_IO_default_xsputn+0x9e)[0x6e559e]
/lib/tls/i686/cmov/libc.so.6(_IO_vfprintf+0xe1c)[0x6b995c]
/lib/tls/i686/cmov/libc.so.6(__vsprintf_chk+0xad)[0x75b6fd]
/lib/tls/i686/cmov/libc.so.6(__sprintf_chk+0x2d)[0x75b63d]
./proxmark3[0x805798c]
/usr/lib/libQtGui.so.4(_ZN7QWidget5eventEP6QEvent+0x524)[0xa65dd4]
/usr/lib/libQtGui.so.4(_ZN19QApplicationPrivate13notify_helperEP7QObjectP6QEvent+0xb4)[0xa10f54]
/usr/lib/libQtGui.so.4(_ZN12QApplication6notifyEP7QObjectP6QEvent+0xda)[0xa185ca]
/usr/lib/libQtCore.so.4(_ZN16QCoreApplication14notifyInternalEP7QObjectP6QEvent+0x7b)[0x5886cb]
/usr/lib/libQtGui.so.4(_ZN14QWidgetPrivate10drawWidgetEP12QPaintDeviceRK7QRegionRK6QPointiP8QPainterP19QWidgetBackingStore+0x525)[0xa6de25]
/usr/lib/libQtGui.so.4[0xbfc2f8]
/usr/lib/libQtGui.so.4[0xbfc77a]
/usr/lib/libQtGui.so.4(_ZN14QWidgetPrivate16syncBackingStoreERK7QRegion+0x65)[0xa5f055]
/usr/lib/libQtGui.so.4[0xa77090]
/usr/lib/libQtGui.so.4(_ZN12QApplication15x11ProcessEventEP7_XEvent+0x1462)[0xa856f2]
/usr/lib/libQtGui.so.4[0xab2502]
/lib/libglib-2.0.so.0(g_main_context_dispatch+0x1f8)[0x7f9e88]
/lib/libglib-2.0.so.0[0x7fd730]
/lib/libglib-2.0.so.0(g_main_context_iteration+0x73)[0x7fd863]
/usr/lib/libQtCore.so.4(_ZN20QEventDispatcherGlib13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE+0x5c)[0x5b302c]
/usr/lib/libQtGui.so.4[0xab1be5]
/usr/lib/libQtCore.so.4(_ZN10QEventLoop13processEventsE6QFlagsINS_17ProcessEventsFlagEE+0x49)[0x586c79]
/usr/lib/libQtCore.so.4(_ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE+0xfa)[0x5870ca]
/usr/lib/libQtCore.so.4(_ZN16QCoreApplication4execEv+0xaf)[0x58953f]
/usr/lib/libQtGui.so.4(_ZN12QApplication4execEv+0x27)[0xa10dd7]
./proxmark3[0x8055c07]
./proxmark3[0x804b49f]
/lib/tls/i686/cmov/libc.so.6(__libc_start_main+0xe6)[0x692b56]
./proxmark3[0x804b391]

Has anybody here an idea how to solve this problem?!

Any help is greatly appreciated!

Regards,
Tom

toffe

Member

Registered: 2010-03-07

Posts: 13

Re: Buffer overflow when issuing "data plot"

Hi,

I'd suggest you register an issue so that we can track this. Thanks!

/K

TomCyber

Member

Registered: 2010-02-15

Posts: 10

Re: Buffer overflow when issuing "data plot"

Hi there,

the issue still occurs on a random basis. Sometimes I am able to plot data, sometimes the program crashes. Sometimes everything works fine until I click into the window, sometimes the program crashes when I issue some data-command like autocorr, etc. But I haven't yet figured out any rule when it works and when it doesn't.

Well, I''ll register an issue as you suggested...

Regards,
Tom

TomCyber

Member

Registered: 2010-02-15

Posts: 10

Re: Buffer overflow when issuing "data plot"

Hi folks,

looks like the problem was fixed with the latest version r438! I couldn't make the plot window crash anymore... ;-)

Thanks to Adam and Hagen!!!

Tom